BrpQueryRow has field deserialization fix #16613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Dec 3, 2024
alice-i-cecile
added
C-Bug
kristoff3r
approved these changes
Dec 3, 2024
|
@alice-i-cecile I have already WIP of serialization tests for remote structs on my machine and I will try to create PR before end of the week, but I wanted to have that merged first, since it is blocking issue for me for using bevy_remote module in my remote inspector. |
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
BrpQueryRow doesn't serialize
hasfield if it is empty. That is okay until you try to deserialize it after. Then it will fail to deserialize due to missing field.Solution
Serde support using default value when field is missing, this PR adds that.