Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example setup for tooling #13088

Merged
merged 6 commits into from
May 2, 2024

Conversation

mockersf
Copy link
Member

Objective

  • Meshlet continuous LOD #12755 introduced the need to download a file to run an example
  • This means the example fails to run in CI without downloading that file

Solution

  • Add a new metadata to examples "setup" that provides setup instructions
  • Replace the URL in the meshlet example to one that can actually be downloaded
  • example-showcase execute the setup before running an example

@mockersf mockersf added A-Build-System Related to build systems or continuous integration C-Examples An addition or correction to our examples labels Apr 24, 2024
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for storing the meshlet in a separate repository in the first place? (cc @JMS55)

Edit:

It looks like the file may get updated frequently. Sounds good 👍

Cargo.toml Show resolved Hide resolved
@alice-i-cecile alice-i-cecile requested a review from JMS55 April 27, 2024 13:36
@@ -726,6 +733,23 @@ fn parse_examples() -> Vec<Example> {
.collect()
})
.unwrap_or_default(),
setup: metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use some helper functions to simplify the nesting/amount of maps and casts and such, but otherwise lgtm.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 1, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 1, 2024
@alice-i-cecile alice-i-cecile removed this pull request from the merge queue due to a manual request May 1, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 2, 2024
Merged via the queue into bevyengine:main with commit 1c15ac6 May 2, 2024
32 checks passed
@mockersf mockersf deleted the example-setup-for-tooling branch May 17, 2024 21:15
@mockersf mockersf restored the example-setup-for-tooling branch May 17, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants