Disable RAY_QUERY and RAY_TRACING_ACCELERATION_STRUCTURE by default #12862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
added
C-Bug
|
I'm recommending we include this in 0.13.2 (despite it being a breaking change) because this breaks 0.13.0. |
james7132
approved these changes
Apr 3, 2024
superdump
reviewed
Apr 4, 2024
| // them until they are safe to enable. | ||
| features -= wgpu::Features::RAY_QUERY; | ||
| features -= wgpu::Features::RAY_TRACING_ACCELERATION_STRUCTURE; | ||
|
|
There was a problem hiding this comment.
This is ok, but maybe the approach for overrides like this should be to add them to the WgpuSettings disabled_features default so that people can still override it if they know better?
There was a problem hiding this comment.
This would mean that setting disabled_features could inadvertently overwrite the default disabled features. I think its best to default that to none.
Users can still set these if they set WgpuSettings::features, which feels like the better pattern.
afonsolage
approved these changes
Apr 4, 2024
mockersf
pushed a commit
that referenced
this pull request
Apr 4, 2024
…12862) # Objective See gfx-rs/wgpu#5488 for context and rationale. ## Solution - Disables `wgpu::Features::RAY_QUERY` and `wgpu::Features::RAY_TRACING_ACCELERATION_STRUCTURE` by default. They must be explicitly opted into now. --- ## Changelog - Disables `wgpu::Features::RAY_QUERY` and `wgpu::Features::RAY_TRACING_ACCELERATION_STRUCTURE` by default. They must be explicitly opted into now. ## Migration Guide - If you need `wgpu::Features::RAY_QUERY` or `wgpu::Features::RAY_TRACING_ACCELERATION_STRUCTURE`, enable them explicitly using `WgpuSettings::features`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
See gfx-rs/wgpu#5488 for context and rationale.
Solution
wgpu::Features::RAY_QUERYandwgpu::Features::RAY_TRACING_ACCELERATION_STRUCTUREby default. They must be explicitly opted into now.Changelog
wgpu::Features::RAY_QUERYandwgpu::Features::RAY_TRACING_ACCELERATION_STRUCTUREby default. They must be explicitly opted into now.Migration Guide
wgpu::Features::RAY_QUERYorwgpu::Features::RAY_TRACING_ACCELERATION_STRUCTURE, enable them explicitly usingWgpuSettings::features