-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bevy_ui/layout] Add tests, missing asserts, and missing debug fields for UiSurface #12803
[bevy_ui/layout] Add tests, missing asserts, and missing debug fields for UiSurface #12803
Conversation
2cbf62b
to
d65c0b2
Compare
cc38996
to
4159fe0
Compare
4159fe0
to
14bcd1e
Compare
14bcd1e
to
7e39ce8
Compare
3df38c1
to
0f0e8bd
Compare
95a690a
to
220601e
Compare
Apply rustfmt Move test_initialization next to other tests Add doc comment to is_root_node_pair_valid Move helper methods into the single test case where they are used Add tests for helper methods Remove trait helpers to reduce complexity of tests Mark specific test functions as unreachable Move ui_surface test only methods into mod tests as trait Fix tests after rebase Add tests for bevy_ui/layout/ui_surface Widen type for parameter children in UiSurface::update_children Add missing asserts and Debug fields in UiSurface from bevyengine#12268 and bevyengine#12698
For now, I've excluded the one test, But I'm not sure I like I removed the change described as "Widen children param in Previously I was using const TEST_LAYOUT_CONTEXT: LayoutContext = LayoutContext {
scale_factor: 1.0, // default 1.0
physical_size: bevy_math::Vec2::ONE, // default Vec2(0,0)
min_size: 0.0, // default 0.0
max_size: 1.0, // default 0.0
}; but changed to using Otherwise, the only outstanding item is this discussion: #12803 (comment) |
I have not looked at the tests in detail, but the default |
Good idea, restored in 03c2f34 |
Thanks for your patience <3 Really nice stuff. |
@StrikeForceZero this needs to be manually updated to reflect the changes on main. Sorry :( I really like this work and would love to get it in though, so please let us know if you're interested in completing this. |
…ace_tests_and_missing
This reverts commit 143b3e7.
Ok, should be good now @alice-i-cecile |
This is 3 of 5 iterative PR's that affect bevy_ui/layout
Objective
UiSurface
_assert_send_sync_ui_surface_impl_safe
camera_entity_to_taffy
Solution
UiSurface
_assert_send_sync_ui_surface_impl_safe
camera_entity_to_taffy