-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't panic in the ECS where we know a fetch is valid #12149
Open
james7132
wants to merge
19
commits into
bevyengine:main
Choose a base branch
from
james7132:dont-panic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+431
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-ECS
Entities, components, systems, and events
C-Performance
A change motivated by improving speed, memory usage or compile times
labels
Feb 27, 2024
james7132
changed the title
Dont panic
Don't panic in the ECS where we know a fetch is valid
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Performance
A change motivated by improving speed, memory usage or compile times
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Partly addresses #12107. We're using panicking
Index
/IndexMut
fetches onTables
andArchetypes
in potentially hot operations in the ECS. This creates a lot of extra codegen when we're we know the corresponding Table or Archetype exists.Solution
Index
andIndexMut
implementations onTables
andArcheytpes
, and replace them withget
/get_mut
where appropriate.Tables::empty
andTables::empty_mut
as the empty table is always guaranteed to exist.DebugCheckedUnwrap
in areas where we we know the table or archetype exist.UnsafeVecExtensions
trait that provides aVec::swap_remove_unchecked
that is the same asswap_remove
but without the safety check. Use it where we are usingswap_remove
like removing component ticks.unwrap
.TODO: Clean up the invariants on unsafe functions and their callsites.
Performance
This PR primarily impacts Entity{Ref/Mut/WorldMut}, command application, and direct World interaction.
TODO: Benchmark.
Changelog
TODO
Migration Guide
TODO