Loosen lifetime requirements for single-threaded Scope::spawn to match the multi-threaded version.
#12073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch the multi-threaded version. This allows the scope itself to be sent to spawned tasks.
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Feb 24, 2024
james7132
approved these changes
Feb 24, 2024
hymm
added
the
S-Ready-For-Final-Review
hymm
approved these changes
Feb 24, 2024
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…tch the multi-threaded version. (bevyengine#12073) # Objective `Scope::spawn`, `Scope::spawn_on_external`, and `Scope::spawn_on_scope` have different signatures depending on whether the `multi-threaded` feature is enabled. The single-threaded version has a stricter signature that prevents sending the `Scope` itself to spawned tasks. ## Solution Changed the lifetime constraints in the single-threaded signatures from `'env` to `'scope` to match the multi-threaded version. This was split off from bevyengine#11906.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…tch the multi-threaded version. (bevyengine#12073) # Objective `Scope::spawn`, `Scope::spawn_on_external`, and `Scope::spawn_on_scope` have different signatures depending on whether the `multi-threaded` feature is enabled. The single-threaded version has a stricter signature that prevents sending the `Scope` itself to spawned tasks. ## Solution Changed the lifetime constraints in the single-threaded signatures from `'env` to `'scope` to match the multi-threaded version. This was split off from bevyengine#11906.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Scope::spawn,Scope::spawn_on_external, andScope::spawn_on_scopehave different signatures depending on whether themulti-threadedfeature is enabled. The single-threaded version has a stricter signature that prevents sending theScopeitself to spawned tasks.Solution
Changed the lifetime constraints in the single-threaded signatures from
'envto'scopeto match the multi-threaded version.This was split off from #11906.