Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the serde feature to bitflags for bevy_render. #11966

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

andriyDev
Copy link
Contributor

Objective

Fixes #11964.

Solution

Adds the serde feature to bitflags for bevy_render. This makes bevy_render compile correctly when used alone.


Changelog

  • Fixed an issue where depending on bevy_render alone would fail to compile.

@andriyDev
Copy link
Contributor Author

Looks like we have two dependencies on async-fs. But that's unrelated to this PR.

@james7132 james7132 added A-Rendering Drawing game state to the screen P-Compile-Failure A failure to compile Bevy apps labels Feb 19, 2024
@james7132 james7132 added this to the 0.13.1 milestone Feb 19, 2024
@james7132 james7132 added this pull request to the merge queue Feb 19, 2024
Merged via the queue into bevyengine:main with commit 2ae5087 Feb 19, 2024
28 of 29 checks passed
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
# Objective

Fixes bevyengine#11964.

## Solution

Adds the `serde` feature to `bitflags` for `bevy_render`. This makes
`bevy_render` compile correctly when used alone.

---

## Changelog

- Fixed an issue where depending on `bevy_render` alone would fail to
compile.
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
# Objective

Fixes bevyengine#11964.

## Solution

Adds the `serde` feature to `bitflags` for `bevy_render`. This makes
`bevy_render` compile correctly when used alone.

---

## Changelog

- Fixed an issue where depending on `bevy_render` alone would fail to
compile.
mockersf pushed a commit that referenced this pull request Feb 27, 2024
# Objective

Fixes #11964.

## Solution

Adds the `serde` feature to `bitflags` for `bevy_render`. This makes
`bevy_render` compile correctly when used alone.

---

## Changelog

- Fixed an issue where depending on `bevy_render` alone would fail to
compile.
@andriyDev andriyDev deleted the fix-bevy-render branch April 9, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen P-Compile-Failure A failure to compile Bevy apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bevy 0.13 RenderAssetUsages fails to build due to serde::Deserialize.
2 participants