Add a [lints] entry for workspace members missing it
#11900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kanabenki
added
A-Build-System
alice-i-cecile
approved these changes
Feb 16, 2024
BD103
approved these changes
Feb 16, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Feb 16, 2024
tguichaoua
approved these changes
Feb 16, 2024
doonv
approved these changes
Feb 17, 2024
We may want to remove this if this is causing a CI failure. |
Missed that it wasn't part of the workspace. @alice-i-cecile thanks for taking care of it! |
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
) # Objective - Some workspace members do not inherit the global lints. ## Solution - Add a `[lints]` entry for all files returned by `rg --files-without-match -F "[lints]" **/Cargo.toml`, except the compile failure tests since these aren't part of the workspace. - Add some docstrings where needed. --------- Co-authored-by: Alice Cecile <[email protected]>
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
) # Objective - Some workspace members do not inherit the global lints. ## Solution - Add a `[lints]` entry for all files returned by `rg --files-without-match -F "[lints]" **/Cargo.toml`, except the compile failure tests since these aren't part of the workspace. - Add some docstrings where needed. --------- Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
[lints]entry for all files returned byrg --files-without-match -F "[lints]" **/Cargo.toml, except the compile failure tests since these aren't part of the workspace.