-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl ExclusiveSystemParam for SystemName #11163
impl ExclusiveSystemParam for SystemName #11163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I'm particularly glad that we're slowly splitting up that huge file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change if you were importing SystemName from system_param::SyatemName
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
@hymm it is not because |
I guess somewhere out there there are tools to detect mechanical API changes automatically and correctly. |
Yeah, the tool in question would be https://crates.io/crates/cargo-semver-checks. Probably worth adding to our CI pipeline down the line. |
Objective
SystemName
might be useful in systems which accept&mut World
.Solution
impl ExclusiveSystemParam for SystemName
SystemName
into a separate file, because it no longer belongs to a file which definesSystemParam
Changelog
impl ExclusiveSystemParam for SystemName