Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageSampler::init_descriptor #11113

Merged
merged 2 commits into from
Aug 26, 2024
Merged

ImageSampler::init_descriptor #11113

merged 2 commits into from
Aug 26, 2024

Conversation

stepancheg
Copy link
Contributor

Shortcut to avoid repetition in code like #11109.

@matiqo15 matiqo15 added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Dec 28, 2023
tychedelia
tychedelia approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is a bit confusing and would prefer something like get_or_init_descriptor, but this seems generally helpful.

@rparrett rparrett added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 21, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 26, 2024
Merged via the queue into bevyengine:main with commit 2e36b27 Aug 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

@matiqo15 matiqo15 matiqo15 approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stepancheg @alice-i-cecile @tychedelia @matiqo15 @rparrett