-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalised ECS reactivity with Observers #10839
Conversation
The generated |
- Provide an expressive way to register dynamic behavior in response to ECS changes that is consistent with existing bevy types and traits as to provide a smooth user experience. - Provide a mechanism for immediate changes in response to events during command application in order to facilitate improved query caching on the path to relations. - A new fundamental ECS construct, the `Observer`; inspired by flec's observers but adapted to better fit bevy's access patterns and rust's type system. --- There are 3 main ways to register observers. The first is a "component observer" that looks like this: ```rust world.observe(|trigger: Trigger<OnAdd, Transform>, query: Query<&Transform>| { let transform = query.get(trigger.entity()).unwrap(); }); ``` The above code will spawn a new entity representing the observer that will run it's callback whenever the `Transform` component is added to an entity. This is a system-like function that supports dependency injection for all the standard bevy types: `Query`, `Res`, `Commands` etc. It also has a `Trigger` parameter that provides information about the trigger such as the target entity, and the event being triggered. Importantly these systems run during command application which is key for their future use to keep ECS internals up to date. There are similar events for `OnInsert` and `OnRemove`, and this will be expanded with things such as `ArchetypeCreated`, `TableEmpty` etc. in follow up PRs. Another way to register an observer is an "entity observer" that looks like this: ```rust world.entity_mut(entity).observe(|trigger: Trigger<Resize>| { // ... }); ``` Entity observers run whenever an event of their type is triggered targeting that specific entity. This type of observer will de-spawn itself if the entity (or entities) it is observing is ever de-spawned so as to not leave dangling observers. Entity observers can also be spawned from deferred contexts such as other observers, systems, or hooks using commands: ```rust commands.entity(entity).observe(|trigger: Trigger<Resize>| { // ... }); ``` Observers are not limited to in built event types, they can be used with any type that implements `Event` (which has been extended to implement Component). This means events can also carry data: ```rust struct Resize { x: u32, y: u32 } commands.entity(entity).observe(|trigger: Trigger<Resize>, query: Query<&mut Size>| { let event = trigger.event(); // ... }); // Will trigger the observer when commands are applied. commands.trigger_targets(Resize { x: 10, y: 10 }, entity); ``` You can also trigger events that target more than one entity at a time: ```rust commands.trigger_targets(Resize { x: 10, y: 10 }, [e1, e2]); ``` Additionally, Observers don't _need_ entity targets: ```rust app.observe(|trigger: Trigger<Quit>| { }) commands.trigger(Quit); ``` In these cases, `trigger.entity()` will be a placeholder. Observers are actually just normal entities with an `ObserverState` and `Observer` component! The `observe()` functions above are just shorthand for: ```rust world.spawn(Observer::new(|trigger: Trigger<Resize>| {}); ``` This will spawn the `Observer` system and use an `on_add` hook to add the `ObserverState` component. Dynamic components and trigger types are also fully supported allowing for runtime defined trigger types. 1. Deprecate `RemovedComponents`, observers should fulfill all use cases while being more flexible and performant. 2. Queries as entities: Swap queries to entities and begin using observers listening to archetype creation triggers to keep their caches in sync, this allows unification of `ObserverState` and `QueryState` as well as unlocking several API improvements for `Query` and the management of `QueryState`. 3. Trigger bubbling: For some UI use cases in particular users are likely to want some form of bubbling for entity observers, this is trivial to implement naively but ideally this includes an acceleration structure to cache hierarchy traversals. 4. All kinds of other in-built trigger types. 5. Optimization; in order to not bloat the complexity of the PR I have kept the implementation straightforward, there are several areas where performance can be improved. The focus for this PR is to get the behavior implemented and not incur a performance cost for users who don't use observers. I am leaving each of these to follow up PR's in order to keep each of them reviewable as this already includes significant changes. --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: MiniaczQ <[email protected]> Co-authored-by: Carter Anderson <[email protected]>
# Objective - Fixes #13825 ## Solution - Cherry picked and fixed non-trivial conflicts to be able to merge #10839 into the 0.14 release branch. Link to PR: #10839 Co-authored-by: James O'Brien <[email protected]> Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: MiniaczQ <[email protected]> Co-authored-by: Carter Anderson <[email protected]>
# Objective `StaticSystemParam` should delegate all `SystemParam` methods to the inner param, but it looks like it was missed when the new `queue()` method was added in #10839. ## Solution Implement `StaticSystemParam::queue()` to delegate to the inner param.
# Objective `StaticSystemParam` should delegate all `SystemParam` methods to the inner param, but it looks like it was missed when the new `queue()` method was added in #10839. ## Solution Implement `StaticSystemParam::queue()` to delegate to the inner param.
# Objective `StaticSystemParam` should delegate all `SystemParam` methods to the inner param, but it looks like it was missed when the new `queue()` method was added in bevyengine#10839. ## Solution Implement `StaticSystemParam::queue()` to delegate to the inner param.
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
bevyengine/bevy-website#1526 caught this as a breaking change, since you can no longer annotate I'm making a PR to fix this, so no further action on this side needs to be done. :) |
Objective
Solution
Observer
; inspired by flec's observers but adapted to better fit bevy's access patterns and rust's type system.Examples
There are 3 main ways to register observers. The first is a "component observer" that looks like this:
The above code will spawn a new entity representing the observer that will run it's callback whenever the
Transform
component is added to an entity. This is a system-like function that supports dependency injection for all the standard bevy types:Query
,Res
,Commands
etc. It also has aTrigger
parameter that provides information about the trigger such as the target entity, and the event being triggered. Importantly these systems run during command application which is key for their future use to keep ECS internals up to date. There are similar events forOnInsert
andOnRemove
, and this will be expanded with things such asArchetypeCreated
,TableEmpty
etc. in follow up PRs.Another way to register an observer is an "entity observer" that looks like this:
Entity observers run whenever an event of their type is triggered targeting that specific entity. This type of observer will de-spawn itself if the entity (or entities) it is observing is ever de-spawned so as to not leave dangling observers.
Entity observers can also be spawned from deferred contexts such as other observers, systems, or hooks using commands:
Observers are not limited to in built event types, they can be used with any type that implements
Event
(which has been extended to implement Component). This means events can also carry data:You can also trigger events that target more than one entity at a time:
Additionally, Observers don't need entity targets:
In these cases,
trigger.entity()
will be a placeholder.Observers are actually just normal entities with an
ObserverState
andObserver
component! Theobserve()
functions above are just shorthand for:This will spawn the
Observer
system and use anon_add
hook to add theObserverState
component.Dynamic components and trigger types are also fully supported allowing for runtime defined trigger types.
Possible Follow-ups
RemovedComponents
, observers should fulfill all use cases while being more flexible and performant.ObserverState
andQueryState
as well as unlocking several API improvements forQuery
and the management ofQueryState
.I am leaving each of these to follow up PR's in order to keep each of them reviewable as this already includes significant changes.