-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tilde
name to KeyCode::Grave
comment
#10495
Conversation
Co-authored-by: Alice Cecile <[email protected]>
this is not the same key on an azerty keyboard |
Yes, but most people use QWERTY. This is only a small comment to help people find the |
Let's add a doc alias as well to make it easier to find in the search :) |
And it will confuse other people... Could you put the Tilde / ~. apart, and mention that it's only on qwerty keyboard then? I've seen enough games put features behind the Tilde key which is not a real key and just doesn't work |
The update to winit 0.29 would make this PR obsolete. I'd take a look at the changes to keyboard input and documentation there |
relevant code: It doesn't add tilde, I'm not particularly against adding it, but from my understanding, keycodes tend to refer to the resulting qwerty key used without modifiers. Also, that code where you want to add docs comes mostly exactly from winit, so I'd be more confortable with keeping an exact copy as much as possible, and upstream any differences within winit to keep differences to a minimum. |
So should I close this? or do something else? |
Let's close this out: I don't think we're going to have a release where it ships. |
Objective
I had trouble finding the
`
/~
key, because I usually call it the tilde key.Solution
Add the name
Tilde
toKeyCode::Grave
's doc comment.