Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Materials: don't reserve items on phase from inside the loop #10437

Closed
wants to merge 1 commit into from
Closed

UI Materials: don't reserve items on phase from inside the loop #10437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/bevy_ui/src/render/ui_material_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,9 +731,12 @@ pub fn queue_ui_material_nodes<M: UiMaterial>(
{
let draw_function = draw_functions.read().id::<DrawUiMaterial<M>>();

for (entity, extracted_uinode) in extracted_uinodes.uinodes.iter() {
let material = render_materials.get(&extracted_uinode.material).unwrap();
for (view, mut transparent_phase) in &mut views {
for (view, mut transparent_phase) in &mut views {
transparent_phase
.items
.reserve(extracted_uinodes.uinodes.len());
for (entity, extracted_uinode) in extracted_uinodes.uinodes.iter() {
let material = render_materials.get(&extracted_uinode.material).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means the material will have to be looked up once per view per entity instead of once per entity

let pipeline = pipelines.specialize(
&pipeline_cache,
&ui_material_pipeline,
Expand All @@ -742,9 +745,6 @@ pub fn queue_ui_material_nodes<M: UiMaterial>(
bind_group_data: material.key.clone(),
},
);
transparent_phase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not if items.len() < uinodes.len() { reserve diff }?

.items
.reserve(extracted_uinodes.uinodes.len());
transparent_phase.add(TransparentUi {
draw_function,
pipeline,
Expand Down