UI Materials: ignore entities with a BackgroundColor component
#10434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
approved these changes
Nov 7, 2023
alice-i-cecile
approved these changes
Nov 7, 2023
cart
pushed a commit
that referenced
this pull request
Nov 30, 2023
) # Objective - Entities with both a `BackgroundColor` and a `Handle<CustomUiMaterial>` are extracted by both pipelines and results in entities being overwritten in the render world - Fixes #10431 ## Solution - Ignore entities with `BackgroundColor` when extracting ui material entities, and document that limit
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…yengine#10434) # Objective - Entities with both a `BackgroundColor` and a `Handle<CustomUiMaterial>` are extracted by both pipelines and results in entities being overwritten in the render world - Fixes bevyengine#10431 ## Solution - Ignore entities with `BackgroundColor` when extracting ui material entities, and document that limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
BackgroundColorand aHandle<CustomUiMaterial>are extracted by both pipelines and results in entities being overwritten in the render worldSolution
BackgroundColorwhen extracting ui material entities, and document that limit