Introduce AspectRatio struct #10368
Merged
Introduce AspectRatio struct #10368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
Co-authored-by: Alice Cecile <[email protected]>
alice-i-cecile
approved these changes
Nov 4, 2023
rparrett
added
the
M-Needs-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
|
Anything I need to do before this can be merged? |
|
Other than resolving merge conflicts, probably not. We need a second reviewer; let me ask around for one. |
100-TomatoJuice
approved these changes
Dec 17, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Merging! FYI, next time you probably want to create a branch with a unique name on your repo for each PR: it really helps you keep things straight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
AspectRatiostruct, as suggested in the issue. This is currently just used in any places where aspect ratio calculations happen, to prevent doing it wrong. In my and @mamekoro 's opinion, it would be better if this was used instead of a normalf32in various places, but I didn't want to make too many changes to begin with.Migration Guide
AspectRatiostruct. this still holds the same value.