Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gate depth reads on !WEBGL2 #10365

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

robtfm
Copy link
Contributor

@robtfm robtfm commented Nov 4, 2023

Objective

fix #10364

Solution

gate depth prepass reads in pbr_transmission.wgsl by #ifndef WEBGL2

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Nov 4, 2023
@alice-i-cecile alice-i-cecile added this to the 0.12 milestone Nov 4, 2023
@cart cart added this pull request to the merge queue Nov 4, 2023
Merged via the queue into bevyengine:main with commit cd59422 Nov 4, 2023
24 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
# Objective

fix bevyengine#10364 

## Solution

gate depth prepass reads in pbr_transmission.wgsl by `#ifndef WEBGL2`
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
# Objective

fix bevyengine#10364 

## Solution

gate depth prepass reads in pbr_transmission.wgsl by `#ifndef WEBGL2`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deferred Rendering example broken on WebGL2
4 participants