Add Color::lerp() convenience method for interpolating/mixing colors
#10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
approved these changes
Nov 1, 2023
|
You often don't want a "mathematically correct" interpolation between colors, but a "perceptually correct" one: https://raphlinus.github.io/color/2021/01/18/oklab-critique.html Marking as controversial, as lerping colors as been a hot topic for a while (#1402 #8189 or many discutions on discord) |
mockersf
added
the
X-Controversial
TimJentzsch
approved these changes
Nov 1, 2023
|
Perhaps, the function should take colorspace as 4th parameter? That would decide how much user would care about performance (sRGB) vs perceptual correctness (Oklab). |
|
#9698 also adds ability to lerp colors |
alice-i-cecile
added
C-Feature
| /// | ||
| /// **Note:** To ensure mathematically correct results, interpolation takes place in linear RGB | ||
| /// colorspace. Both `self` and `rhs` will be converted as necessary, before the operation. | ||
| #[doc(alias = "mix")] |
There was a problem hiding this comment.
Can we add multiple doc aliases? If so, we should add "blend" as well.
| /// will be equal to `rhs`. When `s` is outside of range `[0, 1]`, the result is linearly | ||
| /// extrapolated. | ||
| /// | ||
| /// **Note:** To ensure mathematically correct results, interpolation takes place in linear RGB |
There was a problem hiding this comment.
Suggested change
| /// **Note:** To ensure mathematically correct results, interpolation takes place in linear RGB | |
| /// Interpolation takes place in linear RGB |
|
This should be fixed now, with the addition of bevy_color. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎃🦇🎃🦇🎃🦇🎃🦇🎃🦇🎃🦇
Objective
Color::AQUAMARINE * 0.6 + Color::DARK_GREEN * 0.4;Solution
Color::lerp()method.Changelog
Color::lerp()convenience method for interpolating colors. Colors are interpolated in linear RGB space for mathematically correct results.