Skip to content

Commit

Permalink
Fix taplo CI - toml fmt (#12037)
Browse files Browse the repository at this point in the history
# Objective

- Taplo in CI is not running. The link used to download taplo doesn't
work anymore.

## Solution
- Compile taplo directly with cargo
- Improve docs a little
- Run taplo

---------

Co-authored-by: François <[email protected]>
  • Loading branch information
ameknite and mockersf authored Feb 22, 2024
1 parent 9dfef45 commit 5d3f66f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,20 @@ jobs:
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- name: Install taplo
run: |
curl -fsSL https://github.com/tamasfe/taplo/releases/latest/download/taplo-full-linux-x86_64.gz \
| gzip -d - \
| install -m 755 /dev/stdin /usr/local/bin/taplo
run: cargo install taplo-cli --locked
- name: Run Taplo
id: taplo
run: taplo fmt --check --diff
- name: Taplo info
if: failure()
run: |
echo 'To fix toml fmt, please run `taplo fmt`'
echo 'Or if you use VSCode, use the Even Better Toml extension'
echo 'To check for a diff, run `taplo fmt --check --diff'
echo 'You can find taplo here: https://taplo.tamasfe.dev/'
echo 'Or if you use VSCode, use the `Even Better Toml` extension with 2 spaces'
echo 'You can find the extension here: https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml'
run-examples-on-windows-dx12:
Expand Down
4 changes: 3 additions & 1 deletion crates/bevy_transform/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ thiserror = "1.0"

[dev-dependencies]
bevy_tasks = { path = "../bevy_tasks", version = "0.14.0-dev" }
bevy_math = { path = "../bevy_math", version = "0.14.0-dev", features = ["approx"] }
bevy_math = { path = "../bevy_math", version = "0.14.0-dev", features = [
"approx",
] }
approx = "0.5.1"

[features]
Expand Down

0 comments on commit 5d3f66f

Please sign in to comment.