Actually run code validation in CI #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Feb 5, 2024
alice-i-cecile
added
C-Bug
|
FYI @TrialDragon @RomainMazB :) Review here would be appreciated. |
TrialDragon
approved these changes
Feb 5, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
JMS55
pushed a commit
to JMS55/bevy-website-1
that referenced
this pull request
Feb 13, 2024
RobWalt
pushed a commit
to RobWalt/bevy-website
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
97fef72 was committed to the
new-bookbranch, adding a job to CI that would test all code blocks and validate them. Unfortunately something in #893 messed it up when merging / rebasing. This PR fixes that by configuring the code validation job to actually validate the code.Additionally, it also removes the warning from uploading an empty artifact:
As seen in this run