Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add learn/errors link card to the learn page #843

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Add learn/errors link card to the learn page #843

merged 2 commits into from
Feb 21, 2024

Conversation

TrialDragon
Copy link
Member

This PR makes the page that lists Bevy's errors for current release viewable from the learn page.

Closes #766

@TrialDragon
Add learn/errors link to the learn page
4ffe66e 
Makes a useful page easily reachable to users.
ItsDoot
ItsDoot approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@ItsDoot ItsDoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/learn/links.toml Outdated Show resolved Hide resolved
mockersf
mockersf approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use some variations of the logo on that page, but that's for another PR

@TrialDragon @ItsDoot
Update content/learn/links.toml
cea491d 
Co-authored-by: Christian Hughes <[email protected]>
@TrialDragon TrialDragon added the S-Ready-For-Final-Review Ready for a maintainer to consider for merging label Feb 19, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 21, 2024
Merged via the queue into bevyengine:main with commit efc37b0 Feb 21, 2024
6 checks passed
@TrialDragon TrialDragon deleted the 766_make_learn_errors_reachable branch February 21, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsDoot ItsDoot ItsDoot approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Home C-Usability S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/learn/errors is unreachable
4 participants
@TrialDragon @mockersf @ItsDoot @alice-i-cecile