Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update migration guide for PRs 9419 and 9604 #822

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Update migration guide for PRs 9419 and 9604 #822

merged 1 commit into from
Nov 8, 2023

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Nov 7, 2023

Fixes #821

9419

  • Removed note for maintainers
  • Add an explicit mention of into_world_mut which also got moved to EntityWorldMut.

9604

  • Replaced EntityMut with the new EntityWorldMut, checked that the rest of the example code compiles.

IceSentry
IceSentry approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this change already done during the initial PR? Maybe I overwrote it by mistake

@rparrett
Copy link
Contributor Author

rparrett commented Nov 8, 2023

Wasn't this change already done during the initial PR? Maybe I overwrote it by mistake

Not sure, seems like the note was present in the initial commit and final commit of that PR, and there's no other commit history for that line.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 8, 2023
Merged via the queue into bevyengine:main with commit 169d4f8 Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Migration Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.11->0.12 Migration Guide, rework #9419 and #9604 entries
3 participants
@rparrett @alice-i-cecile @IceSentry