Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in migration guide #799

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Fix typos in migration guide #799

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c09c90
Fix typos in migration guide
rparrett Nov 3, 2023
fa1fb67
Oops
rparrett Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions content/learn/migration-guides/0.11-0.12/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ my_system.map(bevy_utils::error)
<div class="migration-guide-area-tag">ECS</div>
</div>

The type `ManualEventIterator` has been renamed to `EventIterator`. Additonally, `ManualEventIteratorWithId` has been renamed to `EventIteratorWithId`.
The type `ManualEventIterator` has been renamed to `EventIterator`. Additionally, `ManualEventIteratorWithId` has been renamed to `EventIteratorWithId`.

### [Replaced `EntityCommand` Implementation for `FnOnce`](https://github.com/bevyengine/bevy/pull/9604)

Expand Down Expand Up @@ -961,7 +961,7 @@ var model = affine_to_square(mesh[instance_index].model);
<div class="migration-guide-area-tag">Rendering</div>
</div>

The `ComputedVisibilty` component has been split into `InheritedVisiblity` and
The `ComputedVisibility` component has been split into `InheritedVisibility` and
`ViewVisibility`. Replace any usages of `ComputedVisibility::is_visible_in_hierarchy`
with `InheritedVisibility::get`, and replace `ComputedVisibility::is_visible_in_view`
with `ViewVisibility::get`.
Expand All @@ -983,7 +983,7 @@ commands.spawn(VisibilityBundle {

```rust
// 0.11:
fn my_system(q: Query<&ComputedVisibilty>) {
fn my_system(q: Query<&ComputedVisibility>) {
for vis in &q {
if vis.is_visible_in_hierarchy() {

Expand All @@ -995,7 +995,7 @@ fn my_system(q: Query<&InheritedVisibility>) {

```rust
// 0.11:
fn my_system(q: Query<&ComputedVisibilty>) {
fn my_system(q: Query<&ComputedVisibility>) {
for vis in &q {
if vis.is_visible_in_view() {

Expand All @@ -1007,7 +1007,7 @@ fn my_system(q: Query<&ViewVisibility>) {

```rust
// 0.11:
fn my_system(mut q: Query<&mut ComputedVisibilty>) {
fn my_system(mut q: Query<&mut ComputedVisibility>) {
for vis in &mut q {
vis.set_visible_in_view();

Expand Down Expand Up @@ -1151,7 +1151,7 @@ Manual implementations of `AsBindGroup` will need to be adjusted, the changes ar
<div class="migration-guide-area-tag">Rendering</div>
</div>

`MeshPipeline::view_layout` and `MeshPipeline::view_layout_multisampled` have been replaced with a private array to accomodate for variable view bind group layouts. To obtain a view bind group layout for the current pipeline state, use the new `MeshPipeline::get_view_layout()` or `MeshPipeline::get_view_layout_from_key()` methods.
`MeshPipeline::view_layout` and `MeshPipeline::view_layout_multisampled` have been replaced with a private array to accommodate for variable view bind group layouts. To obtain a view bind group layout for the current pipeline state, use the new `MeshPipeline::get_view_layout()` or `MeshPipeline::get_view_layout_from_key()` methods.

### [Update shader imports](https://github.com/bevyengine/bevy/pull/10180)

Expand Down
Loading