Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify generate_wasm_examples.sh #771

Closed
wants to merge 3 commits into from

Conversation

SIGSTACKFAULT
Copy link
Contributor

@SIGSTACKFAULT SIGSTACKFAULT commented Oct 20, 2023

the script was using an unnecessarily convoluted way to clone the bevy repo so i switched it to just git clone --depth 1. also added some comments.

(can squash 3aa2 and 3799 if wanted)

@rparrett
Copy link
Contributor

This isn't quite doing the same thing.

clone_bevy.sh is getting the latest branch. The next parts are retrieving tools from the main branch.

This is probably still necessary until 0.12 is released.

clone_bevy.sh also seems to be used in a few workflows.

@SIGSTACKFAULT
Copy link
Contributor Author

I see. this is my first time with github actions (fluent in gitlab actions) and couldn't tell if act was working because the upload jobs at the end always fail locally.

Turns out there's git clone -b <branch> which can be used instead of the previous complicated system.

should i start a new MR or just keep adding to this one and squash all my mistakes away?

@rparrett
Copy link
Contributor

Feel free to continue here.

@SIGSTACKFAULT
Copy link
Contributor Author

lost the adhd urge so i prolly won't finish this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants