0.12: Add spatial audio API ergonomics section #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably don't deserve authorship here. I feel like I just had average-ish review comments. Maybe add a sentence saying what spatial audio is. i.e. stereo, but not 3-D. |
I disagree -- the PR was in a very poor state when you arrived and your comments revealed some major issues that needed to be fixed! If you would rather not be mentioned though for any reason please let me know. |
|
I'm fine with being mentioned then. Thanks. |
rparrett
changed the title
alice-i-cecile
approved these changes
Oct 26, 2023
cart
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hymm @mockersf please let me know if you don't like what I've done with the authors block or have any other feedback.
I tried to keep this as short as possible. IMO, any other info folks need is in the migration guide. Maybe another sentence explicitly mentioning that
SpatialListenerexists would be nice?