Fix sidebar section highlighter #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't resist, an easy fix. Hopefully improves the feeling. 🙈 |
|
I wonder if something else is going on as well -- this is what I'm seeing on my end with this PR: sidebar.mp4 |
|
Hahaha, OK, that's really broken. It's not because of the header offset feeling. |
doup
changed the title
|
@rparrett I think now is fixed. The sorting of the visible headings was broken, which caused to highlight the last visible heading, not the first one. This is in Safari: fix-sidebar-safari.mp4 |
rparrett
approved these changes
Dec 5, 2024
rparrett
added
C-Bug
cart
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the header offset to
on-this-page.jsintersection observer. This way the sidebar will highlight the next section as soon as the old section gets below the header. Previously it waited until exiting the viewport.Fixes #1908.
New behavior (header opacity reduced to 0.5 and yellow header just for visualization)
fix-on-this-page-highlight.mp4