Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide assets/examples filters to non-JS users #1901

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

doup
Copy link
Contributor

@doup doup commented Dec 3, 2024

Since the beginning the website has favored non-JS solutions when possible. But there are features than can only be implemented with JS. For those users that have JS disabled in their browser we shouldn't show these features.

This PR hides assets/examples filters to non-JS users.

To try this in Firefox:

  • Go to: about:config
  • Set javascript.enabled to false
  • Navigate to assets/examples, you shouldn't see the filters
image image

Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@cart cart added this pull request to the merge queue Dec 10, 2024
Merged via the queue into bevyengine:main with commit 4e9f048 Dec 10, 2024
10 checks passed
@doup doup deleted the hide-js-widgets-by-default branch December 10, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants