Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15 migration: Fix up guide for 16163 #1899

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Dec 3, 2024

This change resulted in some pretty weird-looking breakage and deserves a bit of love. Some of Bevy's examples used these re-exports, so they are likely to be in other codebases.

The list of types was gleaned from changes to Bevy code / examples from the original PR.

@rparrett rparrett changed the title Fix up guide for 16163 0.15 migration: Fix up guide for 16163 Dec 3, 2024
Copy link
Contributor

@mgi388 mgi388 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Dunno if it's worth renaming the file too (re reëxport).

@TrialDragon TrialDragon added A-Migration Guides C-Correction A typo, problem or factual issue in what we've written S-Needs-Review labels Dec 8, 2024
TrialDragon

This comment was marked as off-topic.

Copy link
Member

@TrialDragon TrialDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TrialDragon TrialDragon added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Migration Guides C-Correction A typo, problem or factual issue in what we've written S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants