Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rich Churcher <[email protected]>
  • Loading branch information
alice-i-cecile and bas-ie authored Nov 27, 2024
1 parent 73bdddf commit 297d908
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
The trait method `bevy_asset::io::AssetReader::read` (and `read_meta`) now return an opaque type instead of a boxed trait object. Implementors of these methods should change the type signatures appropriately
The trait method `bevy_asset::io::AssetReader::read` (and `read_meta`) now return an opaque type instead of a boxed trait object. Implementors of these methods should change the type signatures appropriately:

```rust
impl AssetReader for MyReader {
Expand All @@ -15,7 +15,7 @@ impl AssetReader for MyReader {
}
```

`bevy::asset::io::Reader` is now a trait, rather than a type alias for a trait object. Implementors of `AssetLoader::load` will need to adjust the method signature accordingly
`bevy::asset::io::Reader` is now a trait, rather than a type alias for a trait object. Implementors of `AssetLoader::load` will need to adjust the method signature accordingly:

```rust
impl AssetLoader for MyLoader {
Expand Down

0 comments on commit 297d908

Please sign in to comment.