Merge pull request #1 from better/fix/buildkite-hooks-required

better · May 13, 2020 · 59f90b1 · 59f90b1
2 parents 21abc94 + d7b40a5
commit 59f90b1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
@@ -3,7 +3,7 @@ steps:
     plugins:
       - docker-compose#v3.3.0:
           run: lint
-  - label: ":test_tube: Tests"
+  - label: ":karate: Tests"
     plugins:
       - docker-compose#v3.3.0:
           run: tests
diff --git a/README.md b/README.md
@@ -11,14 +11,15 @@ steps:
   - command: ls
     plugins:
       - better/datadog-stats#v1.0.0:
-        name: '*.md'
+        dogstatsd_host: 'localhost'
 ```
 
 ## Configuration
 
-### `name` (Required, string)
+### `dogstatsd_host` (Required, string)
 
-The file name pattern, for example `*.ts`. Supports any pattern supported by [find -name](http://man7.org/linux/man-pages/man1/find.1.html).
+The host where this agent can reach a running instance of dogstatsd for
+reporting metrics to.
 
 ## Developing
 

diff --git a/plugin.yml b/plugin.yml
@@ -7,5 +7,9 @@ requirements:
 configuration:
   properties:
     dogstatsd_host:
-      name: string
+      type: string
+    dogstatsd_port:
+      type: string
+  required:
+    - dogstatsd_host
   additionalProperties: false
diff --git a/tests/post-commands.bats b/tests/post-commands.bats
@@ -35,7 +35,7 @@ load "$BATS_PATH/load.bash"
 
   assert_success
   assert_output --partial "Reporting buildkite.steps.duration as 90"
-  assert_output --partial "tags is_mster:false,pipeline_slug:monorepo,step_command:cd somewhere && make do-something,step_label::shipit: deploy-prod,retry_count:0"
+  assert_output --partial "tags is_master:false,pipeline_slug:monorepo,step_command:cd somewhere && make do-something,step_label::shipit: deploy-prod,retry_count:0"
 
   unset BUILDKITE_PLUGIN_DATADOG_STATS_COMMAND_START_TIME_MS
   unset BUILDKITE_BRANCH