-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amélioration de la recherche par texte sur le tableau de suivi #103
Merged
+251
−186
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
2e45c5c
Amélioration de la recherche par texte sur le tableau de suivi
Ynote 8216db3
Fix sur lindexation
Ynote c174f01
Créer une seule fois lindexation des dossiers
Ynote 845f907
Merge branch 'main' of github.com:betagouv/pitchou into amelioration-…
Ynote 857539f
Gère la recherche par numéro de dossier DS
Ynote 56d38e4
Gestion des accents dans les mots à chercher
Ynote 282313e
Merge branch 'main' of github.com:betagouv/pitchou into amelioration-…
Ynote 27c0f92
Retire test sur le type inutile
Ynote 42488a7
Ajoute un type sur le retour de la fonction créerDossierIndexable
Ynote dd2ed70
Ajoute les communes dans la recherche et gère la recherche par nombres
Ynote b9dd269
Retire filtre inutile nombresEnTexte
Ynote 4b879af
Filtrer uniquement les communes via le code postal
Ynote 6cc9934
Cherche également dans l'id dans la recherche par nombre
Ynote 49955ee
Retire les boosts
Ynote 1f753c9
Ajoute lactivité principale et le numero onagre dans lindex
Ynote c3d6165
Rechercher un dossier dans le numero ONAGRE
Ynote 68e8aa1
Mini-cache pour les resultats de recherche
Ynote 3c04c8c
Restreint la recherche pour les ids, numero onagre et numero DS
Ynote 26d3a2e
Meilleure gestion de la recherche par texte
Ynote 5d89a1a
Utiliser une seule barre de recherche toujours visible
Ynote 52fecfa
Mini ajustements css
Ynote d2aff78
Retire code inutile
Ynote 24f3b3b
Change la regexp pour la recherche par nombre
Ynote 825a1a3
Simplifie la regexp pour matcher les communes
Ynote 4cb708f
Retirer lidentifiant ONAGRE de lindexation des dossiers pour la reche…
Ynote 0d1b46b
Retirer valeur réactive inutile
Ynote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
<script> | ||
//@ts-check | ||
|
||
import { createEventDispatcher } from "svelte"; | ||
|
||
/** @type {string} */ | ||
export let titre | ||
|
||
let valeur = "" | ||
|
||
const dispatch = createEventDispatcher() | ||
|
||
/** | ||
* | ||
* @param {SubmitEvent} e | ||
*/ | ||
function onMettreÀJourValeurSélectionnée(e) { | ||
e.preventDefault() | ||
dispatch("selected-changed", valeur) | ||
valeur = "" | ||
} | ||
</script> | ||
|
||
<form on:submit={onMettreÀJourValeurSélectionnée} role="search"> | ||
<div class="form-recherche"> | ||
<label class="sr-only" for="recherche-texte">{titre}</label> | ||
<input type="text" name="recherche-texte" id="recherche-texte" placeholder="{titre}" class="fr-input" bind:value={valeur} /> | ||
<button class="fr-btn" type="submit">Chercher</button> | ||
</div> | ||
|
||
<p class="fr-hint-text">Vous pouvez rechercher par départements, communes, nom de projet, porteur de projet, activité principale, numéro de dossier, numéro Onagre.</p> | ||
</form> | ||
|
||
<style lang="scss"> | ||
.form-recherche { | ||
display: flex; | ||
width: 70%; | ||
} | ||
|
||
.sr-only { | ||
border: none; | ||
clip: rect(1px, 1px, 1px, 1px); | ||
clip-path: inset(50%); | ||
height: 1px; | ||
margin: -1px; | ||
width: 1px; | ||
overflow: hidden; | ||
position: absolute !important; | ||
word-wrap: normal !important; | ||
} | ||
</style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,6 +79,7 @@ | |
<style lang="scss"> | ||
details { | ||
display: inline; | ||
margin-right: 0.5rem; | ||
} | ||
|
||
.filtre-options { | ||
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c'est un détail, pas forcément besoin de le corriger dans cette PR, mais dans svelte 5, il n'y aura plus d'event
à la place, on passe une props avec une fonction (et cette fonction est appelée par le composant en remplacement des
dispatch
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ! En plus, je crois que tu me l'as déjà mentionné. Ok je vais faire ça dans une PR suivante dans la foulée et voir si on a des
dispatch
ailleurs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf. #114