Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor amounts calculation #1188

Merged
merged 15 commits into from
Nov 12, 2024
Merged

Refactor amounts calculation #1188

merged 15 commits into from
Nov 12, 2024

Commits on Nov 1, 2024

  1. Move calculation methods from concern to manager object to first remo… 

    …ve the concern whilst keeping the callback (first step)
    @pskl
    pskl committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e8073ac View commit details
    Browse the repository at this point in the history

  2. Rm pfmp amount calculator, move tests to pfmp_manager_spec

    @pskl
    pskl committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ee82f9f View commit details
    Browse the repository at this point in the history

  3. Update day count through PfmpManager

    @pskl
    pskl committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8b850cd View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Update all pfmps params through manager to make it consistent

    @pskl
    pskl committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    60799fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into chore/refactor-amount-update

    @pskl
    pskl committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e18305d View commit details
    Browse the repository at this point in the history

  3. Add validation on amounts

    @pskl
    pskl committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    efb3065 View commit details
    Browse the repository at this point in the history

  4. Amend specs

    @pskl
    pskl committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2d7daf4 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Fix specs

    @pskl
    pskl committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    03ad732 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Merge branch 'main' into chore/refactor-amount-update

    @pskl
    pskl committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    38f9ca1 View commit details
    Browse the repository at this point in the history

  2. Remove auto transition!

    @pskl
    pskl committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d60db59 View commit details
    Browse the repository at this point in the history

  3. Fix bad merge

    @pskl
    pskl committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    47bec3c View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Add pessimistic locking for all related pfmps for a given mef

    @pskl
    pskl committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0885fdf View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Remove useless rebalance

    @pskl
    pskl committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d96b7c6 View commit details
    Browse the repository at this point in the history

  2. Make recalculate_amounts a private method of the manager

    @pskl
    pskl committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6b417b6 View commit details
    Browse the repository at this point in the history

  3. Make calculate_amount a private method

    @pskl
    pskl committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    fafc857 View commit details
    Browse the repository at this point in the history