rename d_min related values #775
Conversation
✅ Deploy Preview for origin-blackbox-logviewer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Works great for 4.6, but just shifts the problem to 4.4 and 4.5. Whereas previously, 4.4 and 4.5 were fine, but 4.6 had the problem. Please include version checking so that this change only applies to 4.6, and confirm it works properly, then we can merge. 4.6: |
|
|
|
| const derivativeColumn = document.getElementById("derivativeColumn"); | ||
| const dMaxColumn = document.getElementById("dMaxColumn"); | ||
| const parent = derivativeColumn.parentNode; | ||
| parent.insertBefore(dMaxColumn, derivativeColumn); // Меняем местами |
There was a problem hiding this comment.
Rename column to DMin text here too?
There was a problem hiding this comment.
but it would be more than that... (2 label changes)
4.5:
agree, just a matter of labels could fix.
There was a problem hiding this comment.
master configurator uses DMax verbiage for 4.5, so maybe this is fine as-is
|
Looks a LOT better in 4.5 now! |
It was labeled as Dmax for a long time, but this was done simply by swapping and renaming labels in the code. It still uses the Dmin naming and algorithms, which is why this PR chain was initiated. |
fix related to betaflight/betaflight-configurator#4173