Style: Fix contrast issues on dark mode #4277
Merged
+12
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
haslinghuis
approved these changes
Dec 17, 2024
nerdCopter
approved these changes
Dec 18, 2024
haslinghuis
reviewed
Dec 18, 2024
| @@ -1295,6 +1295,12 @@ dialog { | |||
| &:hover { | |||
| background-color: var(--primary-400); | |||
| } | |||
| &.disabled { | |||
There was a problem hiding this comment.
Suggested change
| &.disabled { | |
| &:disabled { |
There was a problem hiding this comment.
The way it's currently handled is with a class, not a prop. Might be a good fix for a future PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4278 and more.
...
For the canvas-rendered parts I used a neutral (50% value) color that should work well on both dark and light mode, having two options that switch between light and dark mode would be better but I'm not sure how best to implement that consistently
