Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue #4258

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update Vue #4258

wants to merge 2 commits into from

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 22, 2024

Attempting to reconstruct and apply basic migration from 4169 to keep it alive

yarn remove @vitejs/plugin-vue2
yarn remove @panter/vue-i18next
yarn remove vue-template-compiler

yarn add @vitejs/plugin-vue
yarn add vue
yarn add tiny-emitter
yarn add i18next-vue

# yarn add vite --dev
yarn add vue-template-compiler --dev
yarn add @vue/compiler-sfc --dev

Issue is using Vue v3 elements are not updated. Changing options won't reflect for manual, virtual mode. Does not show DFU mode etc. Like the events don't fire or don't reach...

See comment: #4169 (comment)

@haslinghuis haslinghuis added the dependencies Pull requests that update a dependency file label Nov 22, 2024
@haslinghuis haslinghuis added this to the 11.0 milestone Nov 22, 2024
@haslinghuis haslinghuis self-assigned this Nov 22, 2024
@haslinghuis haslinghuis marked this pull request as draft November 22, 2024 22:16
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit f76d591
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6761b7c91cdd2c0008ab0a9d
😎 Deploy Preview https://deploy-preview-4258.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Dec 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

1 participant