-
-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
substitue aircraft
for craft
, drone
, or quad
#4232
substitue aircraft
for craft
, drone
, or quad
#4232
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- unmanned aerial vehicle
- rotorcraft
- multirotor
I'm thinking remain |
I tend to prefer 'aircraft' as an abbreviation for 'model aircraft', rather than 'craft'. Never liked 'craft' much. No-one calls our quads 'craft', not in the real world. We have 'wings' and we have 'quads'. True, we have some hexacopter, tricopters and so on, but they are rare. And we don't want to use 'copter' since 'quads' are not 'helis'. I appreciate that we are also supporting wings much more, but personally unless the tip needs it, I'd say 'quad' still. Some tooltips may have little or no relevance to wings; those that do should speak explicitly about wings. I'd prefer that a general tooltip spoke about 'quads', and if there was no need to change the content, say the same about was the same for wings, then leave it at that. If however a wing has some special requirement or note, eg the new special CLI options for wings, then we speak about 'wings' in that tooltip. Alternatively, if we get very clever, then maybe if the user chooses 'wing' for the mixer type, or the USE_WING DEFINE is included, then all instances of 'craft' or 'quad' become 'wing'. That would be the 'right' way to go :-) PS - when used in the form "to improve the craft's responsiveness', we need an apostrophe before the 's'. |
updated.
if this PR is not important or undesired, happy to close it. the following force-pushes were simply commit message |
fa0d8b4
to
c522a4d
Compare
craft
for drone
and quad
arircraft
for craft
, drone
, or quad
arircraft
for craft
, drone
, or quad
aircraft
for craft
, drone
, or quad
aircraft
for craft
, drone
, or quad
aircraft
for craft
, drone
, or quad
c522a4d
to
c63de5e
Compare
no problem :)
…On Thu, Oct 31, 2024 at 6:19 PM Mark Haslinghuis ***@***.***> wrote:
Sorry for not approving. Agree with @ctzsnooze
<https://github.com/ctzsnooze>. IMO [air]craft is too generic like
calling a race car a vehicle. Some messages apply to quads only. For wings
we probably need other descriptions.
Message ID: <betaflight/betaflight-configurator/pull/4232/c2451007244@
github.com>
|
Why closing? |
|
IMO nothing wrong using |
Our local regulators refer to all the things we fly, whether wings, quads, multi-rotors, helis - as 'model aircraft'. I agree with nerdCopter that the term
Hence, of the two, I prefer My take on My preference therefore would be:
|
Co-authored-by: Mark Haslinghuis <[email protected]>
Quality Gate passedIssues Measures |
I'm late to that PR, sorry... |
* substitue `craft` for `drone` and `quad` * revert `biquad` * possessive * substitue `aircraft` with `craft`; skip languageVariables * Update locales/en/messages.json Co-authored-by: Mark Haslinghuis <[email protected]> --------- Co-authored-by: Mark Haslinghuis <[email protected]>
[Dd]rone
,[Qq]uad
,[Cc]raft
with[Aa]ircraft