Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sensors and battery cellcount #4221

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix sensors and battery cellcount #4221

merged 1 commit into from
Oct 24, 2024

Conversation

haslinghuis
Copy link
Member

  • fixes sensors not shown after applying preset and returning to preset tabs directly after reboot
  • fixes battery icon cell count calculation.

@haslinghuis haslinghuis added this to the 11.0 milestone Oct 23, 2024
@haslinghuis haslinghuis self-assigned this Oct 23, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit e741f7f
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/671977c29ed57500089d7572
😎 Deploy Preview https://deploy-preview-4221.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mituritsyn
Copy link
Contributor

both issues are fixed

@haslinghuis
Copy link
Member Author

haslinghuis commented Oct 23, 2024 •
edited
Loading

Fixed indentation :) + needed rebase 🙄

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nerdCopter
nerdCopter approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving for workflow untested

@haslinghuis haslinghuis merged commit 467b6cc into betaflight:master Oct 24, 2024
8 checks passed
@haslinghuis haslinghuis deleted the fix-sensor-preset branch October 24, 2024 15:43
demvlad pushed a commit to demvlad/betaflight-configurator that referenced this pull request Nov 14, 2024
@haslinghuis @demvlad
Fix sensors and battery cellcount (betaflight#4221)
2fef426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@limonspb limonspb limonspb approved these changes

@VitroidFPV VitroidFPV Awaiting requested review from VitroidFPV

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @mituritsyn @limonspb @nerdCopter