Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of custom configuration with 8 motors, enabling motor testing on octocopters #4213

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

Patronics
Copy link
Contributor

@Patronics Patronics commented Oct 16, 2024

Resolves issue #4212

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 3607552
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6710394e589a090008bead62
😎 Deploy Preview https://deploy-preview-4213.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/js/tabs/motors.js Outdated Show resolved Hide resolved
Co-authored-by: Mark Haslinghuis <[email protected]>
@nerdCopter
Copy link
Member

@limonspb , please check. although it obviously works, i feel it might should be part of the loop or may need to be set with some if/then statement.

src/js/tabs/motors.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 16, 2024

@limonspb
Copy link
Member

@limonspb , please check. although it obviously works, i feel it might should be part of the loop or may need to be set with some if/then statement.

@Patronics did you check if it works ok and/or for standard mixers, and also for motor remapping and motor order dialogs, please?

@haslinghuis
Copy link
Member

haslinghuis commented Oct 16, 2024

@limonspb already tested - this just fixes the assumption made in #2436

See #4213 (comment)

@haslinghuis haslinghuis requested a review from limonspb October 16, 2024 23:01
@Patronics
Copy link
Contributor Author

Patronics commented Oct 16, 2024

@limonspb , please check. although it obviously works, i feel it might should be part of the loop or may need to be set with some if/then statement.

@Patronics did you check if it works ok and/or for standard mixers, and also for motor remapping and motor order dialogs, please?

I've tested the standard mixers, they all seem to behave properly, with one exception, which seems to not quite behave properly before this change either, so seems to be an unrelated bug?

When I tried setting the "Singlecopter" mixer, after a reboot it always seems to be set to the custom mixer instead of singlecopter, and from there it seems to persist whatever motor configuration was added in custom, rather than using the singlecopter mixer? But again the same broken behavior is observed with the released version of betaflight configurator 10.10.0, so I don't believe the issue is related to this PR. It seems to have been documented in the issue betaflight/betaflight#10641, so already a known behavior.

@haslinghuis
Copy link
Member

@Patronics see betaflight/betaflight#10641 (comment) why that happens.

@haslinghuis haslinghuis merged commit cea15f7 into betaflight:master Oct 17, 2024
8 checks passed
demvlad pushed a commit to demvlad/betaflight-configurator that referenced this pull request Nov 14, 2024
…sting on octocopters (betaflight#4213)

* Fix handling of custom configuration with 8 motors
Resolves issue betaflight#4212

* minor optimization since same check is done in for loop above

* Formatting tweak for comment

Co-authored-by: Mark Haslinghuis <[email protected]>

* substitute in equivalent but cleaner logic

---------

Co-authored-by: Mark Haslinghuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants