Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motor wizard fix #4197

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Motor wizard fix #4197

merged 3 commits into from
Oct 2, 2024

Conversation

YarosMallorca
Copy link
Contributor

@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 82509d1
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66fda837fc3c1c0008e5fe6d
😎 Deploy Preview https://deploy-preview-4197.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis added this to the 11.0 milestone Oct 2, 2024
@nerdCopter
Copy link
Member

can you correct the hover-over colors in the Motor Direction --> "wizard" versus "individually"? (light mode, i did not check dark-mode).
in "wizard" hover-over is a light yellow, barely distinguishable, and in "individually" hover-over is an ugly rust color.

@YarosMallorca
Copy link
Contributor Author

@nerdCopter I will look into this later, thanks for pointing it out.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@YarosMallorca
Copy link
Contributor Author

@nerdCopter fixed the highlight color in 82509d1

@YarosMallorca
Copy link
Contributor Author

I was looking at why the image isn't rendering, but I can't figure it out. Maybe @limonspb has an idea on this?

@haslinghuis
Copy link
Member

yarn && yarn preview does show it - yarn && yarn dev not

@haslinghuis haslinghuis merged commit 1748738 into betaflight:master Oct 2, 2024
8 checks passed
@YarosMallorca YarosMallorca deleted the motor-wizard-fix branch October 2, 2024 20:38
@limonspb
Copy link
Member

limonspb commented Oct 2, 2024

yarn && yarn preview does show it - yarn && yarn dev not

Could it be similar problem as was fixed here?
#4158
Maybe some folder is not being copied?

demvlad pushed a commit to demvlad/betaflight-configurator that referenced this pull request Nov 14, 2024
@YarosMallorca @demvlad
Motor wizard fix (betaflight#4197)
927965a 
* Fixed selected color in motor wizards

* removed space

I added it accidentally

* Corrected hover & highlighed color for reorder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@YarosMallorca YarosMallorca

Labels
RN: UI
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@YarosMallorca @nerdCopter @haslinghuis @limonspb