Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket support and fix port override #4187

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 24, 2024

  • Thanks to @AJ92 to get this started using provided websockets client code, had to fix port override, serial shim and serial backend to get it started.

Requirements

Additional info

Alternative protocol

Screenshot from 2024-09-24 18-14-28

@haslinghuis haslinghuis added this to the 11.0 milestone Sep 24, 2024
@haslinghuis haslinghuis self-assigned this Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 37471c5
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66f313f395873b000886ce6d
😎 Deploy Preview https://deploy-preview-4187.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis marked this pull request as draft September 24, 2024 11:48
@haslinghuis haslinghuis mentioned this pull request Sep 24, 2024
52 tasks
@haslinghuis haslinghuis force-pushed the websocket branch 2 times, most recently from d2295da to a885768 Compare September 24, 2024 12:22
src/js/protocols/websocket.js Outdated Show resolved Hide resolved
src/js/protocols/websocket.js Outdated Show resolved Hide resolved
Copy link

@haslinghuis haslinghuis marked this pull request as ready for review September 24, 2024 19:45
@blckmn blckmn requested a review from nerdCopter October 1, 2024 21:33
@nerdCopter
Copy link
Member

how to test? i was able to flash FC.

@AJ92
Copy link

AJ92 commented Oct 2, 2024

how to test? i was able to flash FC.

not related to hw

sitl target needs to be adapted first, if that hasnt been done yet

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving for workflow; i have no clue on this stuff

@haslinghuis haslinghuis changed the title Add websocket support Add websocket support and fix port override Oct 3, 2024
@haslinghuis haslinghuis merged commit 36ccc26 into betaflight:master Oct 3, 2024
8 checks passed
@haslinghuis haslinghuis deleted the websocket branch October 3, 2024 18:03
@haslinghuis
Copy link
Member Author

  • Fixes Vue port override.
  • This PR adds provisional support for websockets (tested with @AJ92 simulator code).
  • Manual mode is broken in PWA without firmware support for websockets or perhaps webtransport.
  • Issue is LWS uses cmake instead of make, so have no clue about integrating the library in firmware.

demvlad pushed a commit to demvlad/betaflight-configurator that referenced this pull request Nov 14, 2024
* Add websocket support

* remove waitforconnection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants