-
-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language option #4174
Add language option #4174
Conversation
haslinghuis
commented
Sep 19, 2024
•
edited
Loading
edited
- fixes Easy language change after installation #4110
- adds language selection to options tab
- keeps language selection on landing tab.
- no refresh required
- For future improvement an icon could improve UX experience
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
263aac5
to
644038c
Compare
This adds the option without removing the selection on the initial page? I think we must let only one option, not both. At the first time this was in the options, it was changed to the main page, and now it seems we want to return to the options again. The only problem for moving it to options, is that if for some reason you have a wrong language, like chinese or similar, it will be difficult to find the options text and select the language. In the welcome page it's always visible. |
Initially that was the case (#1555), but nowadays it's outside the viewport due to more content or lower screen height (especially in browser). 1920x1080 fullscreen: Would also be fine if it stayed on the welcome page and is placed at a more visible position.
It either defaults to your system language or you're already on the options page and deliberately clicked on the dropdown. |
I wanted to implement use of a proper icon pack after we update to Vue 3. I think there were some plans to do this internally, but it was recently done in #4169. Big thanks to @BoldBigflank, I will need to have a proper look at that as well. When we have Vue 3 and a proper icon pack it will be easy to make features like this more accessible regardless of the language selected. The landing page is also planned for a re-design/update, if the default is to follow system language anyway, I think it makes sense for the language option to be in a (properly indicated) options page, maybe with a small |
644038c
to
ea2d985
Compare
Quality Gate passedIssues Measures |