Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language option #4174

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add language option #4174

merged 1 commit into from
Sep 30, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 19, 2024

@haslinghuis haslinghuis added this to the 11.0 milestone Sep 19, 2024
@haslinghuis haslinghuis self-assigned this Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit ea2d985
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66fb35452be96c0008b5901a
😎 Deploy Preview https://deploy-preview-4174.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis force-pushed the language branch 2 times, most recently from 263aac5 to 644038c Compare September 19, 2024 01:11
@McGiverGim
Copy link
Member

This adds the option without removing the selection on the initial page? I think we must let only one option, not both. At the first time this was in the options, it was changed to the main page, and now it seems we want to return to the options again.

The only problem for moving it to options, is that if for some reason you have a wrong language, like chinese or similar, it will be difficult to find the options text and select the language. In the welcome page it's always visible.

@nerdCopter
Copy link
Member

🚀
image

@j4k0xb
Copy link

j4k0xb commented Sep 19, 2024

In the welcome page it's always visible.

Initially that was the case (#1555), but nowadays it's outside the viewport due to more content or lower screen height (especially in browser). 1920x1080 fullscreen:
2024-09-19_16-11

Would also be fine if it stayed on the welcome page and is placed at a more visible position.

The only problem for moving it to options, is that if for some reason you have a wrong language, like chinese or similar, it will be difficult to find the options text and select the language

It either defaults to your system language or you're already on the options page and deliberately clicked on the dropdown.
Another common way to avoid confusion is to use icons:
image

@VitroidFPV
Copy link
Member

I wanted to implement use of a proper icon pack after we update to Vue 3. I think there were some plans to do this internally, but it was recently done in #4169. Big thanks to @BoldBigflank, I will need to have a proper look at that as well. When we have Vue 3 and a proper icon pack it will be easy to make features like this more accessible regardless of the language selected.

The landing page is also planned for a re-design/update, if the default is to follow system language anyway, I think it makes sense for the language option to be in a (properly indicated) options page, maybe with a small Switch back to system language button on the landing page which would not get localized. But overall I'm fine with the option being in either place, though it shouldn't be duplicated IMO - but let's let other people have their say in it a well

Copy link

@haslinghuis haslinghuis merged commit 0a7f22b into betaflight:master Sep 30, 2024
8 checks passed
@haslinghuis haslinghuis deleted the language branch September 30, 2024 23:41
demvlad pushed a commit to demvlad/betaflight-configurator that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Easy language change after installation
6 participants