Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing of presets and vtx tab #4018

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 11.0 milestone Jun 10, 2024
@haslinghuis haslinghuis self-assigned this Jun 10, 2024
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit a5ae22e
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6667852b3dad5d0008c6694b
😎 Deploy Preview https://deploy-preview-4018.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis mentioned this pull request Jun 10, 2024
52 tasks
@haslinghuis haslinghuis changed the title Fix crashing of vtx and preset tab Fix crashing of presets and vtx tab Jun 10, 2024
@limonspb
Copy link
Member

is that crash only in 11.0, or 10.10 also affected?
How to cause this crash?

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis
Copy link
Member Author

haslinghuis commented Jun 10, 2024

@limonspb it's in current master - which is now web only

See #3960 for overview

How to cause this crash?

  • checkout master and do yarn && yarn dev
  • with PWA on first load go to presets or vtx tab to observe the browser resetting.
  • issue is only on first load - reconnect and visit again it works.
  • this PR seems to solve the initial crash.

Note: Preview builds don't work for me

@nerdCopter
Copy link
Member

a5ae22e3 briefly tested, 2 FC's with and without vtxtable set and clearing browser-data/cache, permissions -- no crashes.

@haslinghuis haslinghuis merged commit c7abdac into betaflight:master Jun 11, 2024
7 checks passed
@haslinghuis haslinghuis deleted the fix-crash branch June 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants