Add DFU support for PWA #3949

haslinghuis · 2024-05-12T14:18:25Z

Adds supports for flashing in DFU mode.
We need porthandler support to jump into DFU mode when using serial web API.

Testing using yarn dev

netlify preview build provided does not work (with secure context).
when connected first disconnect before going to firmware flasher tab
after building a config press the flash button and put the device in DFU mode manually
after granting port permission the device will be flashed

On Ubuntu Firefox does not support these web APIs, as snap install of Chromium does not work either.
Need to install package like:

sudo add-apt-repository ppa:xtradeb/apps -y
sudo apt update
sudo apt install chromium

Tested flashing on:

MATEKF411
IFLIGHT_F411_PRO
AOCODARCF405V3
AIRBOTG4AIO
FLYWOOF722PRO
SDMODELH7
NEUTRONF435

netlify · 2024-05-12T14:18:42Z

✅ Deploy Preview for origin-betaflight-app ready!

Name	Link
🔨 Latest commit	`bbdfc16`
🔍 Latest deploy log	https://app.netlify.com/sites/origin-betaflight-app/deploys/6643cfde5de8e000080abbd0
😎 Deploy Preview	https://deploy-preview-3949.dev.app.betaflight.com
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

McGiverGim · 2024-05-12T14:35:31Z

Good work @haslinghuis
I suppose this can't be tested "easilly"? I can't see a way to "add/connect" the device. I suppose that maybe works if it has been authorized before?
I can modify the code to test it, but I want to know exactly what is the expectative with that ;)

chmelevskij · 2024-05-12T18:30:14Z

Will grab a look tomorrow morning. Have few ideas about the webdfu parts

src/js/protocols/webusbdfu.js

chmelevskij · 2024-05-13T05:42:29Z

src/js/protocols/webusbdfu.js

+        .then(result => {
+            if (result.status === 'ok') {
+                const _length = result.data.getUint8(0);
+                let _descriptor = '';
+                for (let i = 2; i < _length; i += 2) {
+                    const charCode = result.data.getUint16(i, true);
+                    _descriptor += String.fromCharCode(charCode);
+                }
+                callback(_descriptor, 0);


I'm not familiar with usb so have a noob question probably.

What populates result.data? Like do we write into that thing, are first 8 bits which represent the length something we write or something standard?

Asking because we could potentially avoid the whole for loop here for string parsing and use TextDecoder instead.

Even if we just cut off the length and pass in the rest text decoder should be able to handle that.

controlTransferIn returns a DataView object containing the data received from the USB device, if any.

src/js/protocols/webusbdfu.js

chmelevskij

Sorry to request this, but I feel like since it's a new file we should aim to get rid of at least the most obvious problems with the old code.

Something to start with:

Removing commented out blocks of code in webdfu.
Removing self = this pattern, it's not relevant anymore with classes and arrow functions.

There is defo more but these would at least put us up for better coding conventions in new code.

haslinghuis · 2024-05-13T16:14:55Z

Tried to remove remaining self in unload_procedure. But then it wont' work.
Could the switch case blocks prevent this to work ? { }
Have implemented and tested commented code

EDIT: refactored whole function and now it works.

chmelevskij · 2024-05-13T17:10:59Z

Tried to remove remaining self in unload_procedure. But then it wont' work.

Could the switch case blocks prevent this to work ? { }

Have implemented and tested commented code

EDIT: refactored whole function and now it works.

Don't know what was the culprit, but it might be that there was function keyword used somewhere in the code. Solution to that is to replace all of the callbacks etc. with arrow functions instead.

Main reason for that pattern in the past was because function binds this to itself. With arrow functions it binds this to closest class/function it's used in.

chmelevskij

LGTM

nerdCopter · 2024-05-14T15:16:38Z

Flash button never enables.

https://build.betaflight.com/api/builds/220ec26ced03bc9893d4d0f48ee9f9ac/log & /hex valid.

Chrome Version 124.0.6367.201 (Official Build) (64-bit) / Debian 12

haslinghuis · 2024-05-14T16:30:19Z

@nerdCopter how did you test?

Works locally (yarn dev). Have not checked on Netlify. This code needs to run in secure context.

Screencast.from.14-05-24.18.18.48.webm

nerdCopter · 2024-05-14T16:46:38Z

@nerdCopter how did you test?

Netlify

nerdCopter · 2024-05-14T18:52:40Z

Okay, i get the DFU via your described process. it does not erase/flash, but the DFU is there.

sonarqubecloud · 2024-05-14T20:56:46Z

Quality Gate failed

Failed conditions
14.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

haslinghuis · 2024-05-14T20:56:58Z

@nerdCopter should work now. Removed flash protection as it does not work on F4 or F7

nerdCopter · 2024-05-15T13:20:30Z

bbdfc167 worked. Chrome connector said STM32 BOOTLOADER. pilots might expect the term DFU.

haslinghuis · 2024-05-15T13:35:16Z

@nerdCopter this is to be expected as PortHandler did all the hard work but currently is disabled for PWA.

Add webusbdfu support for PWA

e371856

haslinghuis added the RN: FEATURE label May 12, 2024

haslinghuis added this to the 11.0 milestone May 12, 2024

haslinghuis self-assigned this May 12, 2024

This comment has been minimized.

Sign in to view

chmelevskij reviewed May 13, 2024

View reviewed changes

src/js/protocols/webusbdfu.js Outdated Show resolved Hide resolved

chmelevskij reviewed May 13, 2024

View reviewed changes

src/js/protocols/webusbdfu.js Show resolved Hide resolved

chmelevskij reviewed May 13, 2024

View reviewed changes

src/js/protocols/webusbdfu.js Outdated Show resolved Hide resolved

chmelevskij reviewed May 13, 2024

View reviewed changes

src/js/protocols/webusbdfu.js Outdated Show resolved Hide resolved

Cleanup

0acc5d0

This comment has been minimized.

Sign in to view

Cleanup more

f4e23c1

This comment has been minimized.

Sign in to view

chmelevskij requested changes May 13, 2024

View reviewed changes

protect flash memory

9dc7ec5

This comment has been minimized.

Sign in to view

Remove self

db5ae18

This comment has been minimized.

Sign in to view

haslinghuis requested a review from chmelevskij May 13, 2024 17:07

chmelevskij approved these changes May 13, 2024

View reviewed changes

haslinghuis requested review from McGiverGim, nerdCopter and a team May 13, 2024 17:16

McGiverGim mentioned this pull request May 13, 2024

Make port_handler work with PWA #3958

Merged

haslinghuis added the Tested label May 13, 2024

haslinghuis changed the title ~~Add webusbdfu support for PWA~~ Add DFU support for PWA May 13, 2024

haslinghuis mentioned this pull request May 13, 2024

PWA project #3960

Open

52 tasks

Fix flashing for F4 and F7

bbdfc16

blckmn approved these changes May 15, 2024

View reviewed changes

nerdCopter approved these changes May 15, 2024

View reviewed changes

haslinghuis merged commit b91698d into betaflight:master May 15, 2024
6 of 7 checks passed

haslinghuis deleted the webdfu branch May 15, 2024 22:24

haslinghuis added the PWA label May 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DFU support for PWA #3949

Add DFU support for PWA #3949

haslinghuis commented May 12, 2024 •

edited

Loading

netlify bot commented May 12, 2024 •

edited

Loading

This comment has been minimized.

McGiverGim commented May 12, 2024

chmelevskij commented May 12, 2024

chmelevskij May 13, 2024

haslinghuis May 13, 2024

This comment has been minimized.

This comment has been minimized.

chmelevskij left a comment

haslinghuis commented May 13, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

chmelevskij commented May 13, 2024

chmelevskij left a comment

nerdCopter commented May 14, 2024 •

edited

Loading

haslinghuis commented May 14, 2024

nerdCopter commented May 14, 2024

nerdCopter commented May 14, 2024

sonarqubecloud bot commented May 14, 2024

haslinghuis commented May 14, 2024

nerdCopter commented May 15, 2024 •

edited

Loading

haslinghuis commented May 15, 2024 •

edited

Loading

Add DFU support for PWA #3949

Add DFU support for PWA #3949

Conversation

haslinghuis commented May 12, 2024 • edited Loading

netlify bot commented May 12, 2024 • edited Loading

✅ Deploy Preview for origin-betaflight-app ready!

This comment has been minimized.

McGiverGim commented May 12, 2024

chmelevskij commented May 12, 2024

chmelevskij May 13, 2024

Choose a reason for hiding this comment

haslinghuis May 13, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

chmelevskij left a comment

Choose a reason for hiding this comment

haslinghuis commented May 13, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

chmelevskij commented May 13, 2024

chmelevskij left a comment

Choose a reason for hiding this comment

nerdCopter commented May 14, 2024 • edited Loading

haslinghuis commented May 14, 2024

nerdCopter commented May 14, 2024

nerdCopter commented May 14, 2024

sonarqubecloud bot commented May 14, 2024

Quality Gate failed

haslinghuis commented May 14, 2024

nerdCopter commented May 15, 2024 • edited Loading

haslinghuis commented May 15, 2024 • edited Loading

haslinghuis commented May 12, 2024 •

edited

Loading

netlify bot commented May 12, 2024 •

edited

Loading

haslinghuis commented May 13, 2024 •

edited

Loading

nerdCopter commented May 14, 2024 •

edited

Loading

nerdCopter commented May 15, 2024 •

edited

Loading

haslinghuis commented May 15, 2024 •

edited

Loading