Fix MSP Radio emulator in PWA #3939
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment has been minimized.
This comment has been minimized.
|
Added a new commit that fixes the issue with the "build" version of PWA. Now works, but maybe my solution is not good enough, but we can make it better with the reviews. I let it in two commits, to see the difference of what's needed for Vite dev and what is needed for Vite build. |
|
|
Do you want to test this code? Here you have an automated build: |
There was a problem hiding this comment.
there is not need really to rename this if we specify the input with rollupOptions
There was a problem hiding this comment.
Not really a tab - could we rename it to /receiver_msp.html instead?
There was a problem hiding this comment.
I tried but it didn't work. My first idea was to add it as subfolder inside the tabs one, and without renaming it, but it didn't work. Maybe I did something wrong, but I didn't found the problem.
There was a problem hiding this comment.
@haslinghuis it seems now it works, I don't know why yesterday don't. I will push a new PR renaming it.
There was a problem hiding this comment.
Not really a tab - could we rename it to /receiver_msp.html instead?
* Fix MSP Radio emulator in PWA * Fix MSP Radio Emulator for PWA build
This makes working again the MSP radio emulator under PWA.
With this changes, it works under PWA and under NW.js.
BUT I've marked it as draft because under PWA only works with
yarn devbut not underyarn review. I suspect it has something to do with https://vitejs.dev/guide/build#multi-page-app but I'm not sure. I tried to add this config to the code without luck. Some idea?