Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose [local] firmware build options #3931

Merged
merged 1 commit into from
May 3, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented May 2, 2024

Since firmware 4.5 build options are provided by firmware instead of relying on cloud queries.

  • Add build type to setup tab
  • Keep using cloud info for build log and config
  • Expose build options for local firmware builds

image
image

@haslinghuis haslinghuis added this to the 11.0 milestone May 2, 2024
@haslinghuis haslinghuis self-assigned this May 2, 2024
@haslinghuis haslinghuis changed the title Fix options and expost local options Fix options and expose local options May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit ee10bb8
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6634180cd6348f0009dc5647
😎 Deploy Preview https://deploy-preview-3931--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis changed the title Fix options and expose local options Fix options and expose local build options May 2, 2024

This comment has been minimized.

This comment has been minimized.

@haslinghuis haslinghuis changed the title Fix options and expose local build options Expose firmware build options May 2, 2024

This comment has been minimized.

@haslinghuis haslinghuis changed the title Expose firmware build options Expose [local] firmware build options May 2, 2024

This comment has been minimized.

Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 2, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis requested a review from a team May 3, 2024 18:13
@nerdCopter
Copy link
Member

nerdCopter commented May 3, 2024

master
image

This PR:
image
image

@haslinghuis haslinghuis merged commit 0f96175 into betaflight:master May 3, 2024
12 checks passed
@haslinghuis haslinghuis deleted the expose-options branch May 3, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants