Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Acro center sensitivity to Betaflight Rates #3927

Merged
merged 2 commits into from
May 21, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented May 1, 2024

This PR makes two important and useful changes to the Rates display window:

  1. For Angle Mode users, displays centre and max stick sensitivity while in Actual and Betaflight Rates. The centre sensitivity is the amount of angle change per unit change in stick position, expressed in degrees as if that sensitivity was to continue linearly to full stick position. The max sensitivity is set by the user's angle_limit CLI value, the maximum angle allowed at full stick input.

Note that in Betaflight 4.5, the old angle_expo_roll and angle_expo_pitch parameters are deprecated and have been removed. The shape of the currently selected rates curve determines the centre sensitivity. The values shown by this PR gives centre and max Angle Mode sensitivity values that are absolute and can be directly compared from one quad to the next.

The user should configure their Rates to suit their acro preference. Usually this will also result in a good Angle mode experience, and will facilitate a smooth transition to Acro Trainer or Horizon Mode. If the user wants greater centre sensitivity, they need to change the shape of the curve, so that the slope in the centre is steeper. In Actual Rates this means increasing the centre sensitivity value. In Betaflight rates more than one parameter affect Center Sensitivity. Regardless of Rates model, the user can use the Angle Mode centre sensitivity value when adjusting their Angle Mode stick feel.

  1. The second big change is to displays centre sensitivity, as well as max rate,for Betaflight Rates. This makes it easy for users of Betaflight Rates to transition to Actual Rates. The centre sensitivity value is directly comparable to (identical to) the centre sensitivity value in Actual Rates.

In both cases the centre sensitivity values update dynamically when the use modify their rates curves.

Note that in 4.5, the Angle Mode user can configure different Rates curves, and that Rates curves can be changed 'on the fly', even mid-flight. However it's generally best to configure your rates to suit your Acro preference, and adapt to how they feel in Angle Mode.

Note also that in Angle Mode the angle_limit value affects overall stick sensitivity. If you fly Acro and find Angle Mode a bit 'dull' in the centre, consider increasing angle_limit rather than changing your rates.

image

@haslinghuis haslinghuis added this to the 11.0 milestone May 1, 2024
@haslinghuis haslinghuis self-assigned this May 1, 2024
Copy link

netlify bot commented May 1, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit b5c4277
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66336cd1609fa20008abd6a2
😎 Deploy Preview https://deploy-preview-3927--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This comment has been minimized.

Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really helpful for:

  • transitioning from Betaflight Rates to Actual Rates
  • learning about which Betaflight Rates parameters affect center sensitivity, and by how much

@haslinghuis
Copy link
Member Author

@ctzsnooze First column header is Acro, but this is already in the bar below, as Acro also shows up in the header on pid tab.

Going to remove the Acro header as duplicate.

image

Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 2, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

interesting, but center vs max is what? center=sensitivity and max=deg/s? because center should be 0 deg/s.
image

@haslinghuis
Copy link
Member Author

@ctzsnooze please add some explanation or documentation.

@haslinghuis haslinghuis requested a review from a team May 20, 2024 22:13
@haslinghuis haslinghuis requested a review from a team May 20, 2024 23:09
@haslinghuis haslinghuis requested a review from McGiverGim May 20, 2024 23:25
@haslinghuis haslinghuis merged commit 48526f2 into betaflight:master May 21, 2024
12 checks passed
@haslinghuis haslinghuis deleted the acro-center-sensitivity branch May 21, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants