Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent race condition #3901

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

haslinghuis
Copy link
Member

Fixes

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 20, 2024
@haslinghuis haslinghuis self-assigned this Apr 20, 2024
Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit ecce9ea
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/662422d7dc2b220008aced66
😎 Deploy Preview https://deploy-preview-3901--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good way I suppose it's to find the underline problem, but as workaround is ok. If finally for PWA this will be rewritten better to not spend time here.

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had to search what it did -- optional chaining

@haslinghuis haslinghuis merged commit 16f70a5 into betaflight:master Apr 20, 2024
11 checks passed
@haslinghuis haslinghuis deleted the fix-setArmingEnabled branch April 20, 2024 21:24
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

3 participants