-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smoothing transition while refreshing sponsor icons #3895
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Quality Gate passedIssues Measures |
Do you want to test this code? Here you have an automated build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to me, maybe it will be prettier doing it from left to right with a little of delay between them, but as is, it's good enough.
For a next PR: the first time that loads the image, it is not smooth. They appear randomly and all images move until all is loaded. I don't know if we can make some kind of "preload" before using it, or at least give them a fixed width, in this way, they will not move around at least when loading not cached images. EDIT: if you want to test it, simply open the "developer tools" (in this way the cache is disabled) in the netlify preview. |
Fade in and out sponsor icons on refresh
Screencast.from.13-04-24.23.58.01.webm