Adding version details to the PWA #3606
Conversation
|
AUTOMERGE: (FAIL)
|
This comment has been minimized.
This comment has been minimized.
Agree. I think the original idea was better, and simply needed the global variables (introduced by Vite definitions) to be marked as readonly. |
Removing whitespace
This comment has been minimized.
This comment has been minimized.
|
@haslinghuis will need someone with SonarCloud access to either give me access or review the security issue (doesn't like git on the path). |
|
SonarCloud Quality Gate failed.
|
| define: { | ||
| '__APP_VERSION__': JSON.stringify(pkg.version), | ||
| '__APP_PRODUCTNAME__': JSON.stringify(pkg.productName), | ||
| '__APP_REVISION__': JSON.stringify(childProcess.execSync("git rev-parse --short HEAD").toString().trim()), |
There was a problem hiding this comment.
The issue is sonarcloud wants the full path to git. It doesn't like that I've let the system search for it... it can just be reviewed as 'safe'.
|
Do you want to test this code? Here you have an automated build: |
* Adding version details to the PWA * Created a coded version.js that can be loaded as a module. * Reverting, and simply identifying the permissible global vars for Vite * Update .eslintrc.js Removing whitespace * Update vite.config.js
Not sure if this is the right way to go about it...