Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: presets styling for web #3585

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: presets styling for web #3585

merged 2 commits into from
Sep 18, 2023

Conversation

chmelevskij
Copy link
Member

  • fix presets styling

@github-actions

This comment has been minimized.

Sign in to view
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

master
2023-09-17_11-45

5b7ef3ef
2023-09-17_11-47

@haslinghuis haslinghuis added this to the 10.10.0 milestone Sep 17, 2023
@chmelevskij chmelevskij marked this pull request as ready for review September 18, 2023 18:50
@blckmn
Copy link
Member

blckmn commented Sep 18, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 5e5aa4f into betaflight:master Sep 18, 2023
9 checks passed
chmelevskij added a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@chmelevskij
fix: presets styling for web (betaflight#3585)
22210f9 
* fix: presets styling for web

* feat: add `isWeb` helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@chmelevskij chmelevskij

Labels
PWA RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chmelevskij @nerdCopter @blckmn @haslinghuis