Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link to documentation in PR template #3584

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Update link to documentation in PR template #3584

merged 1 commit into from
Sep 19, 2023

Conversation

stoneman
Copy link
Contributor

@stoneman stoneman commented Sep 17, 2023 •
edited
Loading

Edit: Description below has been updated. The PR originally updated links in the language files too.

This link is 404ing as there is no /docs directory in the betaflight repo. I'm guessing those docs were moved to betaflight.com so I've updated the link to what I assume is the correct location within https://betaflight.com.

@blckmn
Copy link
Member

blckmn commented Sep 17, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@HThuren
Copy link
Member

HThuren commented Sep 17, 2023

I belive the language file update must be in Crowdin

@haslinghuis
Copy link
Member

We only need to update en locale. Translations are done using crowdin

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stoneman
Copy link
Contributor Author

Changes to language files reverted.

For reference, it's the it, pl & pt_BR files that contain out of date links.

@stoneman stoneman changed the title Update links to documentation Update link to documentation in PR template Sep 17, 2023
@HThuren
Copy link
Member

HThuren commented Sep 17, 2023

Changes to language files reverted.

For reference, it's the it, pl & pt_BR files that contain out of date links.

Maybe @McGiverGim can notify the translators (I don't know howto) ?

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to the 10.10.0 milestone Sep 17, 2023
@haslinghuis haslinghuis merged commit 173b650 into betaflight:master Sep 19, 2023
9 checks passed
@stoneman stoneman deleted the documentation-links branch September 24, 2023 09:58
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@stoneman @chmelevskij
Update link to documentation in PR template (betaflight#3584)
57483ea 
Update link to documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@stoneman stoneman

Labels
Housekeeping
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@stoneman @blckmn @HThuren @haslinghuis @nerdCopter